[Asterisk-code-review] rtp engine.c: Must protect mime types len with mime types lock. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: rtp_engine.c: Must protect mime_types_len with mime_types_lock.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1006/1/main/rtp_engine.c
File main/rtp_engine.c:

Line 606: 	ast_rtp_codecs_payloads_initialize(codecs);
> What does this change have to do with locking mime types?
It doesn't really.

Though the initialization should be done before reporting the changes with the payload_set() callback since the codecs object is totally destroyed by ast_rtp_codecs_payloads_destroy().  This function is rather stupid in that "clearing" means destroying and recreating.  It is a good thing that only chan_mgcp.c calls it for something equally stupid.


-- 
To view, visit https://gerrit.asterisk.org/1006
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44220dd369cc151ebf5281d5119d84bb9e54d54e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes