[Asterisk-code-review] res pjsip sdp rtp.c: Fix processing wrong SDP media list. (asterisk[13])

Mark Michelson asteriskteam at digium.com
Fri Jul 31 12:29:36 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: res_pjsip_sdp_rtp.c: Fix processing wrong SDP media list.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1004/1/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

Line 1243: 	if (set_caps(session, session_media, remote_stream)) {
Are you sure this change is correct? If we are setting capabilities on our session, wouldn't the capabilities be based on our local SDP stream?


-- 
To view, visit https://gerrit.asterisk.org/1004
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c076826c2d3c6ae8c923ca73b7a71980cca11f2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list