[Asterisk-code-review] ARI: Retrieve existing log channels (asterisk[master])

Mark Michelson asteriskteam at digium.com
Fri Jul 31 10:53:17 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: ARI: Retrieve existing log channels
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/987/4/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 567: 				"configuration": {
        : 					"type": "string",
        : 					"description": "The various log levels",
        : 					"required": true
        : 				}
Looking at what this actually has in it, why is this being presented as a string? Wouldn't it make more sense to have this as a list instead?


-- 
To view, visit https://gerrit.asterisk.org/987
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb08b93e3b938c991f3f56cc5d188654768a808
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Scott Emidy <jemidy at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list