[Asterisk-code-review] ARI: Channels added to Stasis application during WebSocket c... (asterisk[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Channels added to Stasis application during WebSocket creation ...
......................................................................


Patch Set 3:

(5 comments)

https://gerrit.asterisk.org/#/c/993/3/res/ari/resource_events.c
File res/ari/resource_events.c:

Line 38: #define APPS_NUM_BUCKETS 11
> That may be an artifact from a refactoring attempt gone awry. Since I hones
Done


Line 49: 	struct ao2_container *message_queue;           /*!< Container for holding delayed
> Ahhhhh, you're right. How. Did. I. Miss. This. Pivotal. Point... Thank you 
Done


Line 96: 	if (!session) {
> Thinking about this... I think it would make more sense as an ast_assert. I
Done


Line 108: 	} else if (!session->ws_session) {
> Yes. Good catch.
Done


Line 511: 	session = ao2_find(event_session_registry, session_id, OBJ_SEARCH_KEY);
> The session doesn't need to remain in the registry past here, it can be unl
Done


-- 
To view, visit https://gerrit.asterisk.org/993
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafef7b85a2e0bf78c114db4c87ffc3d16d671a17
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes