[Asterisk-code-review] ARI: Retrieve existing log channels (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: ARI: Retrieve existing log channels
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/986/2/include/asterisk/logger.h
File include/asterisk/logger.h:

Line 273: int ast_logger_get_channels(int (*logentry)(const char *channel, const char *type,
        :                                             const char *status, const char *configuration,
        :                                             void *data),
        :                             void *data);
You are using spaces instead of tabs.  This looks to be a problem throughout the patch.


https://gerrit.asterisk.org/#/c/986/2/main/logger.c
File main/logger.c:

Line 1138:     if(!configs) {
Guidelines: Space after keywords like if.
if ()


https://gerrit.asterisk.org/#/c/986/2/res/ari/ari_model_validators.h
File res/ari/ari_model_validators.h:

Line 243: ari_validator ast_ari_validate_log_channel_fn(void);
Missing explicit return type.  Does this function return int?

Hmm  This looks to be a problem in the template file or generator code.


https://gerrit.asterisk.org/#/c/986/2/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 299:         {
You used spaces instead of tabs in this file.


-- 
To view, visit https://gerrit.asterisk.org/986
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb08b93e3b938c991f3f56cc5d188654768a808
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Emidy <jemidy at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes