[Asterisk-code-review] res/res rtp asterisk: Add ECDH support (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res/res_rtp_asterisk: Add ECDH support
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.asterisk.org/#/c/977/1//COMMIT_MSG
Commit Message:

Line 19: ciphers with perfect forward secrecy.
       : 
       : Change-Id: I8c13b33a2a79c0bde2e69e4ba6afa5ab9351465b
You need to add the Asterisk issue here.
ASTERISK-25265 #close

https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/#/c/977/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 1291: 	#ifdef HAVE_OPENSSL_ECDH_AUTO
         : 		SSL_CTX_set_ecdh_auto(rtp->ssl_ctx, 1);
         : 	#else
         : 		SSL_CTX_set_tmp_ecdh(rtp->ssl_ctx,
         : 			EC_KEY_new_by_curve_name(NID_X9_62_prime256v1));
         : 	#endif
Please outdent these lines by one.  They are indented too far.


-- 
To view, visit https://gerrit.asterisk.org/977
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c13b33a2a79c0bde2e69e4ba6afa5ab9351465b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Duncan <mark at syon.co.jp>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes