[Asterisk-code-review] Replaces clock gettime() with ast tsnow() (asterisk[master])

[David M. Lee]

David M. Lee has posted comments on this change.

Change subject: Replaces clock_gettime() with ast_tsnow()
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/963/1/include/asterisk/time.h
File include/asterisk/time.h:

Line 145:  * create a timespace from the timeval it returns.
> timespace?  timespec!
You have something against the space-time continuum?


Line 149: struct timespec ast_tsnow(void),
> Oooh look it's ast_t-snow-ing :)
Snow? In July?!?!

You're welcome :-)


Line 162: 	/* Can't use designated initializer, because you can't have a comma
        : 	 * in an AST_INLINE_API. Go figure. */
> This comment doesn't make sense considering that the other version of ast_t
That's weird. Maybe I just have my syntax wrong?

struct timespec ts = {
	.tv_sec = tv.tv_sec,
	.tv_nsec = tv.tv_usec * 1000
};

/Users/dlee/prj/asterisk/git/include/asterisk/time.h:171:1: error: macro "AST_INLINE_API" passed 3 arguments, but takes just 2
 )


-- 
To view, visit https://gerrit.asterisk.org/963
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb1ee67ccf4826b9b76d5a5eb62e90b29b6c456e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: David M. Lee <dlee at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: David M. Lee <dlee at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes