[Asterisk-code-review] Replaces clock gettime() with ast tsnow() (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Fri Jul 24 19:17:55 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: Replaces clock_gettime() with ast_tsnow()
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/963/1//COMMIT_MSG
Commit Message:

Line 15: it falls back to using ast_tsnow().
...using ast_tvnow().


https://gerrit.asterisk.org/#/c/963/1/include/asterisk/time.h
File include/asterisk/time.h:

Line 145:  * create a timespace from the timeval it returns.
timespace?  timespec!


Line 149: struct timespec ast_tsnow(void),
Oooh look it's ast_t-snow-ing :)


Line 162: 	/* Can't use designated initializer, because you can't have a comma
        : 	 * in an AST_INLINE_API. Go figure. */
This comment doesn't make sense considering that the other version of ast_tsnow() has a comma in it.


-- 
To view, visit https://gerrit.asterisk.org/963
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb1ee67ccf4826b9b76d5a5eb62e90b29b6c456e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: David M. Lee <dlee at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list