[Asterisk-code-review] second bundle (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: second bundle
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/948/1/contrib/ast-db-manage/config/versions/31cd4f4891ec_add_auto_dtmf_mode.py
File contrib/ast-db-manage/config/versions/31cd4f4891ec_add_auto_dtmf_mode.py:

Line 50: 
       : 	
Introduction of extraneous whitespace is generally highly discouraged. Please use an editor that shows whitespace, and/or clean up any extraneous whitespace before submitting a patch.

As well, please conform to PEP 8 guidelines. Running your patch through pylint would help a lot.

(There are other obvious infractions, including line length)


-- 
To view, visit https://gerrit.asterisk.org/948
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86e5d40ad6473917a046685a6a9346a2d6524be8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: HZMI8gkCvPpom0tM <fuxfwgc4a2i1gr at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes