[Asterisk-code-review] oracle and spaces to tabs for python indents (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: oracle and spaces to tabs for python indents
......................................................................


Patch Set 2: Code-Review-2

This patch should not be merged.

First, a patch should not perform two functions: that is, to fix compatibility with Oracle _and_ to perform a stylistic change. That should occur in two separate changes.

Second, Python is not supposed to be indented with tabs. This actually takes the Python code out of compliance with PEP 8.

https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces

-- 
To view, visit https://gerrit.asterisk.org/943
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e09b8045eedfae0089e7f8356c165db0cd82bf
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: HZMI8gkCvPpom0tM <fuxfwgc4a2i1gr at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No