[Asterisk-code-review] pjsip: Add rtp timeout and rtp timeout hold endpoint options. (asterisk[13])

[Scott Griepentrog]

Scott Griepentrog has posted comments on this change.

Change subject: pjsip: Add rtp_timeout and rtp_timeout_hold endpoint options.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/941/1/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

Line 1306: 	AST_SCHED_DEL(sched, session_media->timeout_sched_id);
         : 
         : 	/* Due to the fact that we only ever have one scheduled timeout item for when we are both
         : 	 * off hold and on hold we don't need to store the two timeouts differently on the RTP
         : 	 * instance itself.
         : 	 */
         : 	ast_rtp_instance_set_timeout(session_media->rtp, 0);
         : 	if (session->endpoint->media.rtp.timeout && !session_media->held) {
         : 		ast_rtp_instance_set_timeout(session_media->rtp, session->endpoint->media.rtp.timeout);
         : 	} else if (session->endpoint->media.rtp.timeout_hold && session_media->held) {
         : 		ast_rtp_instance_set_timeout(session_media->rtp, session->endpoint->media.rtp.timeout_hold);
         : 	}
         : 
         : 	if (ast_rtp_instance_get_timeout(session_media->rtp)) {
         : 		session_media->timeout_sched_id = ast_sched_add_variable(sched,
         : 			ast_rtp_instance_get_timeout(session_media->rtp) * 1000, rtp_check_timeout,
         : 			session_media, 1);
         : 	}
Is there any possibility that an instance of rtp_check_timeout could fire while simultaneously renogotiating and swapping the longer hold time for a shorter non-hold time, thus causing a timeout before the rtp packets start arriving for the unheld state?


-- 
To view, visit https://gerrit.asterisk.org/941
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f39daaa7da2596b5022737b77799d16204175b9
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes