[Asterisk-code-review] res pjsip: Add rtp keepalive endpoint option. (asterisk[certified/13.1])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip: Add rtp_keepalive endpoint option.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/865/3/contrib/ast-db-manage/config/versions/498357a710ae_add_rtp_keepalive.py
File contrib/ast-db-manage/config/versions/498357a710ae_add_rtp_keepalive.py:

Line 9: # revision identifiers, used by Alembic.
      : revision = '498357a710ae'
      : down_revision = '28b8e71e541f'
Alembic branch merge conflict resolution proceedures need to be done because there are some options not ported to this branch.

/usr/local/lib/python2.7/dist-packages/alembic/util.py:182: UserWarning: Revision 28b8e71e541f referenced from 28b8e71e541f -> 498357a710ae (head), Add RTP keepalive is not present
  warnings.warn(msg)


Line 18:     op.add_column('ps_endpoints', sa.Column('rtp_keepalive', sa.Integer)
Missing closing paren.


-- 
To view, visit https://gerrit.asterisk.org/865
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I683bdc206c8c7def586ecaa64dcf2b86550be3bf
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes