[Asterisk-code-review] chan pjsip: Don't change formats when frame of unsupported f... (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: chan_pjsip: Don't change formats when frame of unsupported format is received.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/905/1/channels/chan_pjsip.c
File channels/chan_pjsip.c:

Line 632: if (ast_format_cap_iscompatible_format(channel->session->endpoint->media.codecs, f->subclass.format) == AST_FORMAT_CMP_NOT_EQUAL) {
        : 		ast_debug(1, "Oooh, got a frame with format of %s on channel '%s' when endpoint '%s' is not configured for it\n",
        : 			ast_format_get_name(f->subclass.format), ast_channel_name(ast),
        : 			ast_sorcery_object_get_id(channel->session->endpoint));
        : 
        : 		return &ast_null_frame;
        : 	}
The only thing that worries me about this change is the cost of doing an iscompatible lookup on every frame read. It may be worth doing a bit of performance testing to see if this has a measurable impact.


-- 
To view, visit https://gerrit.asterisk.org/905
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If93d641fb6418a285928839300d7854cab8c1020
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes