[Asterisk-code-review] res pjsip: Add direct media rtp keepalive test (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res_pjsip: Add direct media rtp_keepalive test
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/900/1/tests/channels/pjsip/rtp/rtp_keepalive/direct_media/configs/ast1/pjsip.conf
File tests/channels/pjsip/rtp/rtp_keepalive/direct_media/configs/ast1/pjsip.conf:

Line 6: [alice]
      : type = endpoint
      : context = default
      : allow = ulaw
      : 
      : [bob]
      : type = endpoint
      : context = default
      : allow = ulaw
      : aors = bob
Shouldn't one of these have rtp_keepalive = True? Otherwise, I wouldn't expect that we would send an RTP keepalive, directmedia or not.


-- 
To view, visit https://gerrit.asterisk.org/900
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23009970201cc07701f8208a652b682f64c11537
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes