[Asterisk-code-review] res pjsip: Add base rtp keepalive test (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res_pjsip: Add base rtp_keepalive test
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

I'll +1 this, although if you feel like fixing the nitpick, that'd be nice too.

https://gerrit.asterisk.org/#/c/899/1/tests/channels/pjsip/rtp/rtp_keepalive/base/rtp.py
File tests/channels/pjsip/rtp/rtp_keepalive/base/rtp.py:

Line 62:             self.test_object.set_passed(False)
       :         self.test_object.set_passed(True)
This is a nitpick, since calling set_passed(True) after set_passed(False) is technically okay, but I think an 'else' here might be nice:

if self.last_rx_time is None:
    self.test_object.set_passed(False)
else:
    self.test_object.set_passed(True)

The cascade from False to True is a bit misleading when you first look at it.


-- 
To view, visit https://gerrit.asterisk.org/899
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd8ea7e980fed140bde337bd6b5462bdc251c3a9
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes