[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.asterisk.org/#/c/807/7/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 207: response, 404, "Not Found",
        : 			"Module is not configured"
> To me, it seems like this could go either way: 404 Not Found, going the rou
I looked into some of the reasons that an AST_MODULE_LOAD_DECLINE would happen:

1) Malformed/missing configuration
2) No bluetooth devices found
3) Failure to register a native RTP, simple, or softmix bridge
4) Failure to register Asterisk Manager Interface CDR Backend
5) Failure to query database columns
6) Missing database
7) Unable to register SQLite CDR handling

and many others...

Maybe this should be a 400 or like you suggested or a 409. But, as stated above, since there are a colorful array of unrelated reasons Asterisk might decline to load/reload/unload a module (and other than a return code, you have no way to know exactly which event triggered the decline), I think the response and reason provided should  be something to the effect that Asterisk declined the action.


-- 
To view, visit https://gerrit.asterisk.org/807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes