[Asterisk-code-review] ARI: Added new functionality to reload a single module. (asterisk[master])

Ashley Sanders asteriskteam at digium.com
Mon Jul 13 14:03:59 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to reload a single module.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/859/1/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 67: "Module does not exist."
Same comment as from the other reviews:

I think that this message should denote that we tried to find the specified resource in order to unload it, but it wasn't currently in our list of running modules, which is a bit different than stating that it does not exist at all. 

Consider something like the following, "Specified module was not found in running modules." (or something to that effect), would give the user an idea that the module may exist in the system (or it may not), but for our purposes, we only looked in the running modules and couldn't find it.


-- 
To view, visit https://gerrit.asterisk.org/859
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I289188bcae182b2083bdbd9ebfffd50b62f58ae1
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list