[Asterisk-code-review] ARI: Added new functionality to get information on a single ... (asterisk[13])

Ashley Sanders asteriskteam at digium.com
Mon Jul 13 13:57:37 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to get information on a single module.
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/790/9/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 75: "reason": "Module does not exist."
I know this is becoming redundant by now... I am only noting it here for consistency. 

I think that this message should denote that we tried to find the specified resource in order to unload it, but it wasn't currently in our list of running modules, which is a bit different than stating that it does not exist at all. 

Consider something like the following, "Specified module was not found in running modules." (or something to that effect), would give the user an idea that the module may exist in the system (or it may not), but for our purposes, we only looked in the running modules and couldn't find it.


-- 
To view, visit https://gerrit.asterisk.org/790
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce5a94e70ecdf4e90329cf0ba66c33a62d37463
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list