[Asterisk-code-review] bridge.c: Fixed race condition during attended transfer (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: bridge.c: Fixed race condition during attended transfer
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/839/3/include/asterisk/bridge_channel_internal.h
File include/asterisk/bridge_channel_internal.h:

Line 146: /*!
        :  * \internal
        :  * \brief Wait for the expected signal.
        :  *
        :  * \param cond the wait object
        :  */
        : void bridge_channel_internal_wait(struct bridge_channel_internal_cond *cond);
        : 
        : /*!
        :  * \internal
        :  * \brief Signal the condition wait.
        :  *
        :  * \param cond the wait object
        :  */
        : void bridge_channel_internal_signal(struct bridge_channel_internal_cond *cond);
Add a \since 13.5.0 and \return Nothing to both of these.


https://gerrit.asterisk.org/#/c/839/3/main/bridge.c
File main/bridge.c:

Line 3975: 	if (b2) ast_bridge_lock_both(b1, b2); \
         : 	else ast_bridge_lock(b1)
For safety please always use curly braces.
Since this is a multi-token macro you should also use the
do {} while (0)
 trick.


Line 4010: 	 * core_local may call into it then the bridges needs to be unlocked here
...bridges need to...unlocked here.  <-- Sentences end with periods.


-- 
To view, visit https://gerrit.asterisk.org/839
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08fe33a2560da924e676df55b181e46fca604577
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes