[Asterisk-code-review] bridge.c: Fixed race condition during attended transfer (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: bridge.c: Fixed race condition during attended transfer
......................................................................


Patch Set 3:

>I don't think the latest revision addresses Richard's concerns about the return value of ast_bridge_impart(). The problem is that there are code paths in bridge_channel_ind_thread() and bridge_channel_depart_thread() where the bridge fails to join the bridge, but ast_bridge_impart() is still returning 0 indicating that the operation was successful.

Apologies up front for not already stating this, but I had spoken with Richard about this particular problem and we agreed on the current solution. If the thread starts up okay, but the channel fails to enter the bridge there is nothing the initiating thread can, or really needs to, do with that channel since it no longer has control of the channel. So that made the return value essentially useless, so it was dropped.

-- 
To view, visit https://gerrit.asterisk.org/840
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08fe33a2560da924e676df55b181e46fca604577
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No