[Asterisk-code-review] ARI: Added new functionality to get information on a single ... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: ARI: Added new functionality to get information on a single module.
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/790/4/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 167: 	ast_json_object_set(data, "name", ast_json_string_create(module));
        : 	ast_json_object_set(data, "description", ast_json_string_create(description));
        : 	ast_json_object_set(data, "use_count", ast_json_integer_create(usecnt));
        : 	ast_json_object_set(data, "status", ast_json_string_create(status));
        : 	ast_json_object_set(data, "support_level", ast_json_string_create(
        : 	                    ast_module_support_level_to_string(support_level)));
What happens if an ast_json_objectset fails?


Line 201: 			ast_ari_response_alloc_failed(response);
Looks like there is an extra indention here.


Line 205: 	ast_update_module_list_condition(&identify_module, NULL, json, args->module_name);
Should this be checking the result? If no conditions were met should it still return okay?


-- 
To view, visit https://gerrit.asterisk.org/790
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce5a94e70ecdf4e90329cf0ba66c33a62d37463
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes