[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/814/2/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 71: 							"reason": "Module could not be loaded."
> That may be the only 409 it will receive, hence the elaboration within the 
Okay. If there are a boat load of reasons that a module could possibly fail to load, then sure. You are correct. 

If there was just one or two causes that a module would not load, or if it was relatively easy to modify the reason dynamically, then I could see revising the message. Otherwise, I think it's fine to leave it as a simple statement.


-- 
To view, visit https://gerrit.asterisk.org/814
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-HasComments: Yes