[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/814/2/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 71: 							"reason": "Module could not be loaded."
> This is a general purpose reason. The code itself is what gives a more desc
Except that it does not, at least not really. 

If you look at bridges.json, line 594ish, we give a really good reason why recording on the given bridge is not going to work. 

The definition of a 409 states that there is a conflict of some kind, which to me, is not really indicative of exactly what the conflict was that blocked the module from being loaded.

If you look at the RFC (see http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html), you will see the following in the definition for a 409 Status Code:
-------------
The response body SHOULD include enough information for the user to recognize the source of the conflict. Ideally, the response entity would include enough information for the user or user agent to fix the problem; however, that might not be possible and is not required.
-------------

So, even though it is not required for you to provide more information, my thoughts are that it sure would be nice if we could do that to help the user out.


-- 
To view, visit https://gerrit.asterisk.org/814
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-HasComments: Yes