[Asterisk-code-review] bridge.c: Fixed race condition during attended transfer (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: bridge.c: Fixed race condition during attended transfer
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/840/2/include/asterisk/bridge_channel_internal.h
File include/asterisk/bridge_channel_internal.h:

Line 154:  * \retval the condition's result.
This retval should be explained more clearly. What values are good and what values are bad?


Line 163:  * \param res the result to use
Same here. What results are good and what results are failures?


-- 
To view, visit https://gerrit.asterisk.org/840
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08fe33a2560da924e676df55b181e46fca604577
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes