[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/807/2/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 161: 			response, 409, "Conflict",
        : 			"Module could not be loaded");
> Shouldn't this be 404 not found?
No, ast_module_check() determines if the module is already loaded. If the module is already loaded, then 409 is the proper response code.


-- 
To view, visit https://gerrit.asterisk.org/807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes