[Asterisk-code-review] DNS: Create a system-level DNS resolver (asterisk[master])

Ashley Sanders asteriskteam at digium.com
Tue Jul 7 15:19:01 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: DNS: Create a system-level DNS resolver
......................................................................


Patch Set 7:

(4 comments)

https://gerrit.asterisk.org/#/c/749/7/main/dns.c
File main/dns.c:

Line 396:  * \brief Extended version of the DNS Parsing function. Parses the DNS lookup result and notifies
> \brief should be a single line description of the function.  Use an additio
Done.


Line 437: 		ast_log(LOG_WARNING, "Length of DNS answer exceeds available search frames \n");
> Extraneous space before \n.
Done.


Line 472: 			ast_log(LOG_WARNING, "Length of DNS answer exceeds available search frames \n");
> Extraneous space before \n.
Done.


https://gerrit.asterisk.org/#/c/749/7/main/dns_system_resolver.c
File main/dns_system_resolver.c:

Line 70:  * \brief Callback to handle processing an individual resource record discovered from ast_search_dns_ex.
> \brief should be a single line description of the function.  Use an additio
Done.


-- 
To view, visit https://gerrit.asterisk.org/749
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b36ea17b889a98df4f8d80d50bb7ee175afa077
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list