[Asterisk-code-review] ARI: Added new functionality to get information on a single ... (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: ARI: Added new functionality to get information on a single module.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/790/2/main/loader.c
File main/loader.c:

Line 1446: 		condition_met += modentry(cur->resource, cur->info->description, cur->usecount,
The doxygen for this function claims that it will return 0 if the condition is not met or 1 if it is. However, since addition is used here, condition_met may end up getting set to a positive value higher than 1. So, you have two ways to go here:

1) Change the doxygen so that it indicates that it returns the number of conditions that were met
2) Alter the behavior here so that you can guarantee either a 0 or 1 return value.


-- 
To view, visit https://gerrit.asterisk.org/790
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce5a94e70ecdf4e90329cf0ba66c33a62d37463
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes