[Asterisk-code-review] DNS: Create a system-level DNS resolver (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: DNS: Create a system-level DNS resolver
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/#/c/749/5/include/asterisk/dns_system_resolver.h
File include/asterisk/dns_system_resolver.h:

Line 32: int ast_dns_system_resolver_init(void);
> I agree with you. Although this was already declared in _private.h, I was g
It failed because the _private.h file was not included in the dns_system_resolver.c file most likely.


https://gerrit.asterisk.org/#/c/749/5/main/dns.c
File main/dns.c:

Line 250: static int dns_search_res_n(const char *dname, int rr_class, int rr_type,
> If I understand you correctly, that is already present below (see the ast_s
It's not. You can have a mix of both by moving the define checks outside and having it compile in different function implementations instead, both with the same name.

The ast_search_dns function would call the same function name - but it would go to a different implementation.


-- 
To view, visit https://gerrit.asterisk.org/749
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b36ea17b889a98df4f8d80d50bb7ee175afa077
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes