[Asterisk-code-review] ARI: Added new functionality to get information on a single ... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: ARI: Added new functionality to get information on a single module.
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/790/1/include/asterisk/module.h
File include/asterisk/module.h:

Line 164:  * \brief Ask for a list of modules, descriptions, use counts and status.
        :  * \param modentry A callback to an updated function.
        :  * \param like
        :  * \param data Data to pass to the callback
        :  * \param condition The condition to meet
        :  *
Add a \since tag to this documentation (which should be 13.5.0)


https://gerrit.asterisk.org/#/c/790/1/main/loader.c
File main/loader.c:

Line 1448:             data, condition);
It looks like this was indented with spaces. I'd align it properly using tabs with the previous parameters passed to modentry.


https://gerrit.asterisk.org/#/c/790/1/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 191: 	json = ast_json_object_create();
This memory allocation can fail. If it does, you need to return a server error and bail.


Line 209: 	ast_update_module_list_condition(&identify_module,NULL,&json,args->module_name);
Spaces between arguments passed to a function please


https://gerrit.asterisk.org/#/c/790/1/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 60: 					"errorResponses": [
       : 						{
       : 							"code": 404,
       : 							"reason": "Module does not exist."
       : 						}
       : 					]
This can also return a 400 if moduleName is not provided.


-- 
To view, visit https://gerrit.asterisk.org/790
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce5a94e70ecdf4e90329cf0ba66c33a62d37463
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes