[Asterisk-code-review] res pjsip: Failover when server is not available (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Jul 6 09:44:48 CDT 2015


Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Failover when server is not available
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/750/3/res/res_pjsip.c
File res/res_pjsip.c:

Line 3155: 	/*
         : 	 * Bump the ref since it will be on a new transaction and
         : 	 * we don't want it to go away along with the old transaction.
         : 	 */
         : 	pjsip_tx_data_add_ref(tdata);
Isn't the fact that it needs a ref a detail of the caller of this?


-- 
To view, visit https://gerrit.asterisk.org/750
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief14f4ebd82474881f72f4538f4577f30af2a764
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list