[Asterisk-code-review] Channel alert pipe: improve diagnostic error return (asterisk[master])
Richard Mudgett
asteriskteam at digium.com
Wed Jul 1 14:38:07 CDT 2015
Richard Mudgett has posted comments on this change.
Change subject: Channel alert pipe: improve diagnostic error return
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/752/1/main/channel_internal_api.c
File main/channel_internal_api.c:
Line 1206: /* preset errno in case returned size does not match */
: errno = EPIPE;
Should move this assignment to after the if statement to better associate why it is being set.
--
To view, visit https://gerrit.asterisk.org/752
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf7b3337ad392789a9f02c650589cd065d20b5b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list