[Asterisk-code-review] res pjsip: Failover when server is not available (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Failover when server is not available
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/750/1/res/res_pjsip.c
File res/res_pjsip.c:

Line 3153: 	pjsip_tx_data_invalidate_msg(old_data);
         : 	pjsip_tx_data_add_ref(old_data);
         : 
         : 	*new_data = old_data;
This isn't creating a new request though. It's manipulating the old one and returning a ref to it. Should this function be renamed?


https://gerrit.asterisk.org/#/c/750/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 2337: 			check_request_status(inv, e);
While this won't do anything for now - should a break be added?


-- 
To view, visit https://gerrit.asterisk.org/750
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief14f4ebd82474881f72f4538f4577f30af2a764
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes