[Asterisk-code-review] main/pbx: Split pbx builtin functions to pbx builtins.c (asterisk[13])

Corey Farrell asteriskteam at digium.com
Wed Dec 30 18:48:46 CST 2015


Corey Farrell has posted comments on this change.

Change subject: main/pbx: Split pbx_builtin functions to pbx_builtins.c
......................................................................


Patch Set 5:

(2 comments)

The commit message still needs work.  We are no longer splitting pbx_builtin functions - we are moving only the builtin dialplan applications.

https://gerrit.asterisk.org/#/c/1878/5//COMMIT_MSG
Commit Message:

Line 11: pbx_functions.c and a new pbx_private.h file was added.  load_pbx_builtins()
pbx_builtins.c


Line 14: A few functions were renamed and are cross-exposed between the 2 c files.
'two sources' instead of '2 c files'?


-- 
To view, visit https://gerrit.asterisk.org/1878
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87066be3dbf7f5822942ac1449d98cc43fc7561a
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list