[Asterisk-code-review] main/pbx: Split pbx builtin functions to pbx builtins.c (asterisk[13])

George Joseph asteriskteam at digium.com
Wed Dec 30 16:10:16 CST 2015


Hello Anonymous Coward #1000019, Joshua Colp, Corey Farrell,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/1878

to look at the new patch set (#5).

Change subject: main/pbx: Split pbx_builtin functions to pbx_builtins.c
......................................................................

main/pbx: Split pbx_builtin functions to pbx_builtins.c

We joked about splitting pbx.c into multiple files but this first step was
fairly easy.  All of the pbx_builtin functions have been moved into
pbx_functions.c and a new pbx_private.h file was added.  load_pbx_builtins()
is called by asterisk.c just after load_pbx().

A few functions were renamed and are cross-exposed between the 2 c files.

Change-Id: I87066be3dbf7f5822942ac1449d98cc43fc7561a
---
M include/asterisk/_private.h
M main/asterisk.c
M main/pbx.c
A main/pbx_builtins.c
A main/pbx_private.h
5 files changed, 1,551 insertions(+), 1,476 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/78/1878/5
-- 
To view, visit https://gerrit.asterisk.org/1878
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87066be3dbf7f5822942ac1449d98cc43fc7561a
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list