[Asterisk-code-review] main/pbx: Split pbx builtin functions to pbx builtins.c (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: main/pbx: Split pbx_builtin functions to pbx_builtins.c
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.asterisk.org/#/c/1878/3/main/pbx.c
File main/pbx.c:

Line 100: 	<application name="Answer" language="en_US">
> Documentation should be moved with the dialplan apps.
Totally missed them


Line 11284: 	res |= load_pbx_builtins(&globals, &globalslock);
> I don't agree with the dual-ownership of globals/globalslock.  These variab
Done


https://gerrit.asterisk.org/#/c/1878/3/main/pbx_private.h
File main/pbx_private.h:

Line 32: void unload_pbx_builtins(void);
       : int load_pbx_builtins(struct varshead *g, ast_rwlock_t *l);
> Can we move load_pbx_builtins to asterisk/_private.h and make unload_pbx_bu
Done


Line 34: int pbx_builtin_congestion(struct ast_channel *, const char *);
       : int pbx_builtin_busy(struct ast_channel *, const char *);
> These symbols were previously static.  Can we remove the pbx_ prefix from t
I'm going to remove the pbx_ but leave them where they are.  Moving them into channels.h seems overkill when no other module uses them.


-- 
To view, visit https://gerrit.asterisk.org/1878
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87066be3dbf7f5822942ac1449d98cc43fc7561a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes