[Asterisk-code-review] main/pbx: Split pbx builtin functions to pbx builtins.c (asterisk[13])

George Joseph asteriskteam at digium.com
Tue Dec 29 13:21:12 CST 2015


Hello Anonymous Coward #1000019, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/1878

to look at the new patch set (#3).

Change subject: main/pbx: Split pbx_builtin functions to pbx_builtins.c
......................................................................

main/pbx: Split pbx_builtin functions to pbx_builtins.c

We joked about splitting pbx.c into multiple files but this first step was
fairly easy.  All of the pbx_builtin functions have been moved into
pbx_functions.c and a new pbx_private.h file was added.  pbx.c:load_pbx
calls pbx_builtins.c:load_pbx_builtins with globals and globalslock as
parameters so pbx_builtins.c can use them without making them public.
Only a few other functions needed to be cross-exposed.

Change-Id: I87066be3dbf7f5822942ac1449d98cc43fc7561a
---
M main/pbx.c
A main/pbx_builtins.c
A main/pbx_private.h
3 files changed, 1,180 insertions(+), 1,086 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/78/1878/3
-- 
To view, visit https://gerrit.asterisk.org/1878
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87066be3dbf7f5822942ac1449d98cc43fc7561a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list