[Asterisk-code-review] res http websocket.c: prevent avoidable disconnections cause... (asterisk[11])

[Dade Brandon]

Dade Brandon has posted comments on this change.

Change subject: res_http_websocket.c: prevent avoidable disconnections caused by write errors
......................................................................


Patch Set 1:

Hi guys.  FYI, we found and patched this over a year ago, so we know this works.  We had a reproduce-able scenario with one server that apparently had the exact required network conditions to one of our test rigs, that would cause the first write to succeed, and the second to fail, even though when combined, it succeeds, and concurrent writes also succeed.  This occurred during periods of high SIP messaging to that machine, presumably linux's write buffer for the socket was at the end of the header, and got flushed before more data was available to be sent.

-- 
To view, visit https://gerrit.asterisk.org/1863
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4db7a586af1c7a57184c31d3d55bf146f1a40598
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Dade Brandon <dade at xencall.com>
Gerrit-Reviewer: Dade Brandon <dade at xencall.com>
Gerrit-HasComments: No