[Asterisk-code-review] tests/apps/queues/reason pause ami: Add 'PausedReason' field... (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: tests/apps/queues/reason_pause_ami: Add 'PausedReason' field test AMI
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

What you have here looks good to me (except for the one minor finding).

The testsuite is great in that it is flexible and usually offers a couple of different ways to do things. If you are interested I am fairly certain this same test could be accomplished without writing any python and only yaml by using the EventActionModule. See tests/bridge/atxfer_fail_blonde/test-config.yaml for a working example.

https://gerrit.asterisk.org/#/c/1848/1/tests/apps/queues/reason_pause_ami/test-config.yaml
File tests/apps/queues/reason_pause_ami/test-config.yaml:

Line 8:     minversion: '13.6.0'
More than likely the PausedReason changes will end up going in 13.8.0


-- 
To view, visit https://gerrit.asterisk.org/1848
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04ad41f7a39a319f58cf40abeb9434fc02b6d767
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes