[Asterisk-code-review] res pjsip history: Add a module that provides PJSIP history ... (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip_history: Add a module that provides PJSIP history for debugging
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.asterisk.org/#/c/1849/4/res/res_pjsip_history.c
File res/res_pjsip_history.c:

Line 65: 	/*! \brief Time the packet was received */
Or transmitted?


Line 340: 	return evaluate_less_than(op, type, op_left, op_right) || evaluate_equal(op, type, op_left, op_right);
You could save a cycle or two by changing this to
    return !evaluate_greater_than()


Line 348: 	return evaluate_greater_than(op, type, op_left, op_right) || evaluate_equal(op, type, op_left, op_right);
You could save a cycle or two by changing this to

    return !evaluate_less_than()


-- 
To view, visit https://gerrit.asterisk.org/1849
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39bd74ce998e99ad5ebc0aab3e84df3a150f8e36
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes