[Asterisk-code-review] app queue: Add member flag "in call" to prevent reading wron... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_queue: Add member flag "in_call" to prevent reading wrong lastcall time
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/1847/1/apps/app_queue.c
File apps/app_queue.c:

Line 2325: 		available = 0; // member is still in call, cant check wrapuptime to lastcall time
Guidelines: No C++ style comments.


Line 5400: 				ast_debug(4, "Marked member %s as NOT in_call. Lastcall time: %ld \n", mem->membername, (long)mem->lastcall);
Guidelines: Break long lines at 90 in a convenient spot.

This should be done for several of the lines you have added with the patch.


-- 
To view, visit https://gerrit.asterisk.org/1847
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1923230cf9859ee51563a8ed420a0628b4d2e500
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes