[Asterisk-code-review] res rtp asterisk: Resolve further timing issues with DTLS ne... (asterisk[11])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_rtp_asterisk: Resolve further timing issues with DTLS negotiation
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1838/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 1675: 			dtls_srtp_flush_pending(instance, rtp); // flushes pending BIO for both rtp & rtcp as needed.
Use /* and */ at the line above


Line 1672: 		if (rtp->dtls.dtls_setup != AST_RTP_DTLS_SETUP_PASSIVE)
         : 			dtls_perform_handshake(instance, &rtp->dtls, 0);
         : 		else
         : 			dtls_srtp_flush_pending(instance, rtp); // flushes pending BIO for both rtp & rtcp as needed.
         : 
         : 
         : 		if (rtp->rtcp && rtp->rtcp->dtls.dtls_setup != AST_RTP_DTLS_SETUP_PASSIVE)
         : 			dtls_perform_handshake(instance, &rtp->rtcp->dtls, 1);
Even for single lines coding standards have { and } being used.


-- 
To view, visit https://gerrit.asterisk.org/1838
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2caedbdee1783159f375589b6fd3845c8577ba5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Dade Brandon <dade at xencall.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dade Brandon <dade at xencall.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes