[Asterisk-code-review] json: Audit ast json * usage for thread safety. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: json: Audit ast_json_* usage for thread safety.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1828/1/main/stasis_channels.c
File main/stasis_channels.c:

Line 1039: 		"digit", digit,
         : 		"duration_ms", duration_ms,
> Hmm.  Does this get represented differently when converted to text?
They are equivalent. In the original case a string object was passed in from the blob. In the new case a separate string object is constructed by ast_json_pack internally.


-- 
To view, visit https://gerrit.asterisk.org/1828
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06550d8b0cc1bfeb56cab580a4e608ae4f1ec7d1
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes