[Asterisk-code-review] RFC: Add runtime option that allows automatic realtime execu... (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: RFC: Add runtime option that allows automatic realtime execution.
......................................................................


Patch Set 1:

(3 comments)

As far as a comment about the general implementation it looks decent enough to me. I am not sure of a better way to currently do this.

https://gerrit.asterisk.org/#/c/1803/1/lib/python/asterisk/test_case.py
File lib/python/asterisk/test_case.py:

Line 232: self.global_config.config.get('asterisk-instances')):
Optionally: 'asterisk-instances' in self.global_config.config


https://gerrit.asterisk.org/#/c/1803/1/lib/python/asterisk/test_runner.py
File lib/python/asterisk/test_runner.py:

Line 139:         realtime_class = 'realtime_converter.RealtimeConverter'
Since you have the global config here would it make sense to have the class as a configurable option too that defaults to the RealtimeConverter?


Line 134:     if realtime:
        :         # Realtime conversion pluggable module needs to be loaded. Its
        :         # configuration is found in the global test-config.yaml file, in the
        :         # "realtime-config" section.
        :         realtime_config = test_object.global_config.realtime_config
        :         realtime_class = 'realtime_converter.RealtimeConverter'
        :         module_type = load_and_parse_module(realtime_class)
        :         module_type(realtime_config, test_object)
What would happen if a test also had a realtime plugin configured non-globally?

Since this is a acting as a global plugin should this occur before loading other plugins? That way a test with a specific realtime configuration can override it (fully or partially).


-- 
To view, visit https://gerrit.asterisk.org/1803
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec1b1cfa48cadab108c4ab65122ce36ab697e4e
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes