[Asterisk-code-review] chan sip: Enable WebSocket support by default. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: chan_sip: Enable WebSocket support by default.
......................................................................


Patch Set 1:

> It wouldn't get into remove_protocol, since websocket_was_enabled and sip_cfg.websocket_enabled would be equal.

True, but would it ever fall into that section of the code? Seems like the second check will mostly evaluate to true, except maybe on a change between reloads?

-- 
To view, visit https://gerrit.asterisk.org/1832
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb02bbcad47b11a795c14ce20a9bf29649a54423
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No