[Asterisk-code-review] json: Audit ast json * usage for thread safety. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: json: Audit ast_json_* usage for thread safety.
......................................................................


Patch Set 1:

Unfortunately as Richard has pointed out using o comes at a cost - specifically that in off-nominal error cases you aren't guaranteed that the object passed in will be unreffed. This problem exists in code written since the original usage. If we can ensure that in off-nominals the reference is still dropped, then we'd be golden to just switch completely.

-- 
To view, visit https://gerrit.asterisk.org/1828
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06550d8b0cc1bfeb56cab580a4e608ae4f1ec7d1
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No