[Asterisk-code-review] tests/sorcery/memory cache populate: Add 'SorceryMemoryCache... (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: tests/sorcery/memory_cache_populate: Add 'SorceryMemoryCachePopulate' AMI test.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1809/1/tests/sorcery/memory_cache_populate/test-config.yaml
File tests/sorcery/memory_cache_populate/test-config.yaml:

Line 7:          1. PJSIP endpoints are configured with a memory cache and realtime.
      :          2. A PJSIP endpoint is defined in realtime at the start of the test.
      :          3. The PJSIPShowEndpoint AMI action is invoked which populates the memory cache.
      :          4. The PJSIP endpoint is removed from realtime.
      :          5. The SorceryMemoryCachePopulate AMI action is invoked on the memory cache.
      :          6. The PJSIPShowEndpoint AMI action is invoked to confirm the endpoint
      :             CAN NOT be retrieved as it should not exist in realtime or the cache.'
How do you know it is actually being retrieved from the cache? I think one more step after #4 (delete it from the realtime) where you retrieve it before calling populate would show that. Then follow up with the #5.


-- 
To view, visit https://gerrit.asterisk.org/1809
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04b19fe6ccdd97c26fc1482ffe07162e575554e4
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes