[Asterisk-code-review] AMI: Fixed OriginateResponse message (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: AMI: Fixed OriginateResponse message
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/1805/4/main/manager.c
File main/manager.c:

Line 5003: 			chan ? ast_channel_name(chan) : requested_channel, in->context, in->exten, reason,
> Break the long line after "requested_channel,"
While this is a fine suggestion, this does match the code that was already here. Generally, for code that is this old, we don't knock changes that more or less merely preserve the existing code.

If the author would like to make the code conform better to the coding guidelines on the wiki - https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines - that'd be great.

For merely stylistic points, a little bit of leniency and reasonableness in the findings would be appreciated, however.


-- 
To view, visit https://gerrit.asterisk.org/1805
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26f54f677ccfb0b7cfd4967a844a1657fd69b74d
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-HasComments: Yes