[Asterisk-code-review] Fixed OriginateResponse message (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Fixed OriginateResponse message
......................................................................


Patch Set 4: Code-Review-1

(7 comments)

https://gerrit.asterisk.org/#/c/1805/4//COMMIT_MSG
Commit Message:

Line 7: Fixed OriginateResponse message
AMI: Fixed OriginateResponse message.


Line 9: When the asterisk sending OriginateResponse message,
      : it doesn't set the "Uniqueid".
      : And it didn't support correct response message for
      : Application originate.
      : Added XML object.
      : Fixed wrong commit.
This paragraph should be saying what the commit is about.  It should not be describing the history of the patch creation.

What is "Fixed wrong commit." referring to?


Line 16: ASTERISK-25624
Add " #close" to the end of this line.


https://gerrit.asterisk.org/#/c/1805/4/main/manager.c
File main/manager.c:

Line 4986: 			chan ? ast_channel_name(chan) : requested_channel, in->app, in->appdata, reason,
Break the long line after "requested_channel,"


Line 4987: 			S_OR(in->channelid, "<unknown>"),
This line should be:
chan ? ast_channel_uniqueid(chan) : S_OR(in->channelid, "<unknown>"),

This allows for successful originates to report a consistent channel name and uniqueid.  This is needed if the originate did not supply the uniqueid for the channel.


Line 5003: 			chan ? ast_channel_name(chan) : requested_channel, in->context, in->exten, reason,
Break the long line after "requested_channel,"


Line 5004: 			S_OR(in->channelid, "<unknown>"),
This line should be:
chan ? ast_channel_uniqueid(chan) : S_OR(in->channelid, "<unknown>"),

This allows for successful originates to report a consistent channel name and uniqueid.  This is needed if the originate did not supply the uniqueid for the channel.


-- 
To view, visit https://gerrit.asterisk.org/1805
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26f54f677ccfb0b7cfd4967a844a1657fd69b74d
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-HasComments: Yes