[Asterisk-code-review] Fix ASTERISK-25614 "DTLS negotiation delays" (asterisk[11])

Dade Brandon asteriskteam at digium.com
Mon Dec 14 14:22:58 CST 2015


Dade Brandon has posted comments on this change.

Change subject: Fix ASTERISK-25614 "DTLS negotiation delays"
......................................................................


Patch Set 1:

I'm hoping someone with in depth knowledge of the DTLS mutexes can review the added lock.

I added it where I did, since the call to dtls_srtp_stop_timeout_timer uses the same locks (so the added locks are after.)

The locks were not necessary to resolve the issue at hand, but since we are writing to the BIO structure, I thought it to be necessary.

Based on pcaps, the DTLS packets account for a very small portion of the packets received on an RTP stream, and are more concentrated at the start, rather than once we're fully bridged and passing audio back and forth, so I don't expect any performance penalty.

-- 
To view, visit https://gerrit.asterisk.org/1813
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I547f1be7e302dbf71f6553dd8cbc0657b1d0b908
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Dade Brandon <dade at xencall.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Dade Brandon <dade at xencall.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list