[Asterisk-code-review] Fixed OriginateResponse message (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: Fixed OriginateResponse message
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1805/1/main/manager.c
File main/manager.c:

Line 4977: 			"Application: %s\r\n"
         : 			"Data: %s\r\n"
You are changing the documented response of OriginateResponse, these are not in it:

https://wiki.asterisk.org/wiki/display/AST/Asterisk+13+ManagerEvent_OriginateResponse

(This is defined at the top of the file, it should be updated)


Line 4985: 			chan ? ast_channel_uniqueid(chan) : in->channelid,
This assumes that in->channelid will be set which it won't always be. I think it should use S_OR(in->channelid, "<null>") so if the value is not set then the old behavior will occur.


-- 
To view, visit https://gerrit.asterisk.org/1805
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26f54f677ccfb0b7cfd4967a844a1657fd69b74d
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes